Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve dfx cycles messages. #3972

Merged
merged 6 commits into from
Nov 12, 2024
Merged

chore: improve dfx cycles messages. #3972

merged 6 commits into from
Nov 12, 2024

Conversation

vincent-dfinity
Copy link
Contributor

@vincent-dfinity vincent-dfinity commented Nov 5, 2024 •
edited
Loading

Description

Improve the messages for the subcommands of dfx cycles to let users know what to do next.

$ dfx cycles balance
Error: The replica returned a rejection error: reject code DestinationInvalid, reject message IC0301: Canister um5iw-rqaaa-aaaaq-qaaba-cai not found, error code Some("IC0301")
Error explanation:
Cycles ledger with canister ID 'um5iw-rqaaa-aaaaq-qaaba-cai' is not installed.
How to resolve the error:
Run the command with '--ic' flag if you want to manage the cycles on the mainnet.

Fixes # (issue)

SDK-1864

How Has This Been Tested?

Added the e2e test.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@vincent-dfinity vincent-dfinity marked this pull request as ready for review November 5, 2024 07:42
@vincent-dfinity vincent-dfinity requested a review from a team as a code owner November 5, 2024 07:42
@vincent-dfinity vincent-dfinity changed the title chore: improve dfx cycles balance message. chore: improve dfx cycles messages. Nov 5, 2024
@vincent-dfinity vincent-dfinity merged commit 6af08b9 into master Nov 12, 2024
297 checks passed
@vincent-dfinity vincent-dfinity deleted the vincent/SDK-1864 branch November 12, 2024 09:35
@sesi200 sesi200 mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sesi200 sesi200 sesi200 approved these changes

@marydwyer marydwyer Awaiting requested review from marydwyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-dfinity @sesi200